Replace tabled-based settings form markup with do_settings_sections() in Twenty Eleven

[chipbennett]

Currently, Twenty Eleven uses a hard-coded, table-based markup for its Theme Options page. Patch replaces this markup with do_settings_sections(), corresponding call to add_settings_section(), and calls to add_settings_field() for each Theme Option.

One other, minor change: changed theme_options_render_page() function name to twentyeleven_theme_options_render_page(), to correspond to function prefix best practices.

I would like to add in more inline documentation to this file, in general; but want to get at least a blessed first-pass on the code changes while I work on improving the documentation.

implements do_settings_sections(), add_settings_section(), and add_settings_field() to replace hard-coded, table-based settings page markup

Moving to 3.2.1. Don't expect it then, but would like to roll it out in a Twenty Eleven point release.

Crap. I'm not sure how we missed theme_options_render_page().

That needs to be fixed.

Well let me know if there's anything else that needs to be fixed/addressed/polished up in the patch, and I'll get it turned back around.

Or, if you would prefer, I could pull the theme_options_render_page() fix out into its own patch, for expediting?

Attached patch:

• Moves add_settings_section and add_settings_field calls into twentyeleven_theme_options_init().

• Removes unneeded $default_options variables from each of the settings fields callbacks.

• Provides a way to hide the section title, in do_settings_sections.

In [18430]:

Twenty Eleven: Prefix theme_options_render_page(). props chipbennett, see #18045. for trunk.

In [18431]:

Twenty Eleven: Prefix theme_options_render_page(). props chipbennett, see #18045. for 3.2.

Soaking the rest in trunk and punting this to 3.2.2.

In [18432]:

Don't echo empty <h3>s if we don't pass a section title to add_settings_section(). see #18045.

Refreshed.

Refreshed the patch based on [18430] and [18432]. Patch now just registers the settings section and fields and moves the HTML bits into helper functions. Works great. Happy to soak it in trunk now.

In [18455]:

Use the Settings fields/sections API in Twenty Eleven. props chipbennett for initial patch. see #18045. for 3.3.

In [18458]:

Fix @sinces in Twenty Eleven. see #18045.