Opened 23 months ago
Closed 20 months ago
#18047 closed enhancement (fixed)
Add edit link to confirmation page for new network site
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | Network Admin | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
Screen: Network Admin -> Sites -> Add New
After completing the form to create a new site on a network install, I think it would be handy to have an "Edit new site" link that takes the admin directly to /network/site-info.php?id=[NewSiteID]
Attachments (2)
Change History (9)
comment:1
SergeyBiryukov — 21 months ago
- Keywords has-patch added
Based on SergeyBiryukov's patch for #17313, I added an additional link directly to the edit site page.
- Milestone changed from Awaiting Review to 3.3
- Owner set to PeteMall
- Status changed from new to assigned
- Type changed from feature request to enhancement
+1. $_GETsite_id? will need absint() before going directly into a URL parameter. XSS hole otherwise.
Probably fine as id rather than site_id.
The 'or' isn't translatable. Probably better to do this:
sprintf( __( 'Site added. <a href="%1$s">Visit Dashboard</a> or <a href="%2$s">Edit Site</a>' ), first link, second link )
SergeyBiryukov — 20 months ago
comment:4
follow-up:
↓ 5
SergeyBiryukov — 20 months ago
18047.2.patch includes the suggestions.
Replying to SergeyBiryukov:
18047.2.patch includes the suggestions.
I tested this locally and it works like a charm. Thanks, Nacin/Sergey!
- Keywords commit added
I'd feel more comfortable with $_GET['site_id'] being absint()'d before going into get_admin_url().
Since site_id is often referring to the network rather than the blog, I'd rather see this be just "id."
Related: #17313