id	summary	reporter	owner	description	type	status	priority	milestone	component	version	severity	resolution	keywords	cc
18086	Taxonomy Rewrite Strips Spaces from Querystring Vars	MathSmath	dd32	"'''Overview'''[[BR]]
On custom taxonomy listings pages, adding pagination vars will cause any custom querystring vars to be stripped of all spaces on rewrite.
[[BR]][[BR]]
For example, the request[[BR]][[BR]]

/my-categories/test-one/page/2/?something=one+two[[BR]][[BR]]

is rewritten to[[BR]][[BR]]

/my-categories/test-one/page/2/?something=onetwo[[BR]][[BR]]

This does not happen on the initial results page. For example, if you visit[[BR]][[BR]]

/my-categories/test-one/?something=one+two[[BR]][[BR]]

The space stays intact in the custom querystring var.[[BR]][[BR]]

'''Steps to reproduce'''[[BR]]

1) Clean install of trunk, with no plugins enabled, using the default theme.[[BR]]
2) Create a custom taxonomy and apply it to any content type (I used posts for my test, but this problem also occurs with custom content types). Does not seem to matter whether you use a custom slug or not when defining the taxonomy.[[BR]]

{{{
register_taxonomy(
	'my-categories',
	array(
		'post',
	),
	array(
		'hierarchical' => true,
		'label' => 'My Categories'
	)
);
}}}

3) Add a term to the new taxonomy using the admin, and assign it to an item or series of items.[[BR]]
4) Visit the archive page for that term, adding any custom variable to the querystring. This custom variable should be two words (for example, ""?something=one+two"")[[BR]]
5) Either manually, or using next/previous links, navigate to a secondary results page (ex. /page/2/), keeping your custom variable intact.[[BR]][[BR]]

Any spaces in the custom variable are stripped. This happens no matter how the spaces are urlencoded (as a plus, as %20, or as actual spaces). Adding the custom variable to the vars list using the query_vars filter has no effect."	defect (bug)	closed	normal	3.3	Canonical		normal	fixed	has-patch