Opened 23 months ago

Last modified 17 months ago

#18088 new defect (bug)

Network Admin Email setting in wp-admin/network/settings.php fails silently

Reported by: kawauso Owned by:
Priority: normal Milestone: Future Release
Component: Network Admin Version: 3.2
Severity: normal Keywords: has-patch
Cc: xoodrew@…

Description

Steps to reproduce:

  1. Go to wp-admin/network/settings.php
  2. Try setting your email to support@localhost
  3. Page reports success but email remains the same

The check in wp-admin/network/edit.php consists of:

if ( is_email( $_POST['admin_email'] ) )
	update_site_option( 'admin_email', $_POST['admin_email'] );

which doesn't account for anything not passing is_email()

I know network admins should know what they're doing, but failing silently is a pretty sure-fire way to generate confusion.

Attachments (1)

18088.patch​ (496 bytes) - added by SergeyBiryukov 21 months ago.

Download all attachments as: .zip

Change History (4)

SergeyBiryukov — 21 months ago

comment:1   SergeyBiryukov — 21 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

comment:2   ryan — 20 months ago

  • Milestone changed from 3.3 to Future Release

settings.php needs quite a bit of work. Let's punt this from 3.3 and put in proper error notification as part of a general cleanup.

comment:3   DrewAPicture — 17 months ago

  • Cc xoodrew@… added
Note: See TracTickets for help on using tickets.