Users with capes don't need promote_users on their new role

[nacin]

When setting your own role:

		// The new role of the current user must also have promote_users caps
		if ( $id == $current_user->ID && !$wp_roles->role_objects[$_REQUEST['new_role']]->has_cap('promote_users') ) {
			$update = 'err_admin_role';
			continue;
		}

There's no reason to prevent a super admin from demoting themselves on a site.

How does one get a cape?

Step 1 - Visit ​http://www.superherosupplies.com/

Step 2 - Add cape to cart

Step 3 - Go through check out procedure

Step 4 - Wait for delivery truck

Step 5 - Receive and Open package - find out it's shoes your wife ordered, go back outside to wait for delivery truck

Step 6 - Receive package - open - find cape

Step 7 - Wear cape.

Step 8 - Commence core hacking.

Checks for cape before deciding if user can demote himself.

The more generic is_super_admin() would probably be a better fit here.

Thanks for the tip! I've updated the patch to use is_super_admin()

In [19024]:

Allow a super admin to demote themselves on a site to a role that does not contain the promote_users cap. props fonglh, fixes #18164.

Thanks for the patch, fonglh!

No problem! Glad to have been able to make my first contribution to core.