Upload installs of plugins/themes not cleaning up after themselves

[hew]

Upload installs of plugins and themes are not removing the .zip file after installation.

To reproduce:

1. Upload a zipped theme or plugin via Themes->Install->Upload or Plugins->Install->Upload.
2. Check /wp-content/uploads and you should see the zip left over from install.

This was caused by [17660] - which I thought I'd tested this code branch properly.

Ultimately, The uploaded file shouldn't be moved to the uploads directory at all with the current uploader, It appears to have been written with Ajax uploading in mind (Not sure that's something we really need for the plugin/theme uploaders).

The code that moves the file to the uploads directory just needs to be removed by looks of it, but i'll do some more testing.

Setting to 3.3 for now, Will need to go into the 3.2 branch as well.

Ultimately, The uploaded file shouldn't be moved to the uploads directory at all with the current uploader

Unfortunately, I was forgetting about FTP upgrades, the file needs to be uploaded and stored for the following request.

Previously if a user was to upload a theme, but not follow through with the install (ie. prompted for FTP details) the zip file wouldn't be deleted either.

Proposed patches:

• 3.2.x: Just clean up after ourselves after installing.
• 3.3: We should store uploaded items in the Media Library somehow, and as well as deleteing after installing, a cron job should clean up any non-installed items.

3.2.x patch and initial 3.3 patch

In [18614]:

Clean up Plugin/Theme uploads after successfully installing them. Restores pre-3.2 behaviour. See #18182

In [18615]:

Clean up Plugin/Theme uploads after successfully installing them. Restores pre-3.2 behaviour. See #18182 for 3.2.x

In [18616]:

Only clean up the uploaded files after a successful (or failed) install. Allows files to persist past the FTP credential screen. See #18182

In [18617]:

Store Plugin/Theme uploads in the Media Library properly. Add Scheduled cleanup +2hrs to clean up any aborted installation attempts. See #18182

[18616]

That needs to be (in part at least) applied to 3.2.x as well. Needs more testing on my end before the final 3.2.x patch is done.

In [18713]:

Only clean up the uploaded files after a successful (or failed) install. Allows files to persist past the FTP credential screen. See #18182

Calling this one as done for 3.2 and trunk.

• 3.2.2, 3.3: Clean up uploaded files after successful installations
• 3.2.2, 3.3: Clean up uploaded files after failed installations
• 3.3: Store uploads in the Media Library temporarily with the context flag set, Clean up any aborted(ie. see the FTP credentials page, and give up) installation files 2hours after install attempt.