Opened 22 months ago

Last modified 4 months ago

#18282 reviewing defect (bug)

Issue with admin page hierarchy in Menu admin

Reported by: hcceast Owned by:
Priority: normal Milestone: Awaiting Review
Component: Menus Version: 3.2.1
Severity: major Keywords: needs-patch
Cc: frandeazevedo@…, Whissi, marc@…

Description

Under Appearance > Menus in the left column under Pages, if I have more than 50 pages, the hierarchy view gets messed up. The issue seems to be related to paginate.

If I change the "50" on lines 589 and 809 of wp-admin/includes/nav_menu.php to "955" the hierarchal admin menu works with 50+ pages.

Attached are two XML files. One contains 50 pages and the other contains 53 pages. I've loaded them into fresh installs of 3.2.1 using the twenty eleven theme and no plugins.

Paginate is great if it works right, if it won't work, just increase the number per page to something very high and people can scroll. I'd rather scroll than not have hierarchy work right.

Link to 50 page XML -- http://cloud.hcc.me/0g3X3O310s3l3i2N363n

Link to 53 page XML -- http://cloud.hcc.me/302e0c391A14193m2V2e

Pastebin of wp-admin/includes/nav_menu.php -- http://pastebin.com/0FRAmMkS

Attachments (2)

page xml .zip (7.1 KB) - added by hcceast 22 months ago.
XML Page Files
Screen shot 2011-07-28 at 10.03.43 AM.png (30.6 KB) - added by hcceast 22 months ago.
Screen shot of admin menu (all subs should be under parents)

Download all attachments as: .zip

Change History (17)

XML Page Files

Screen shot of admin menu (all subs should be under parents)

Taxonomies are also affected.

Closed #19837 and #20351 as duplicates.

  • Cc frandeazevedo@… added

I suspect the $depth parameter could be failing during pagination.
I'll take a look into it see if I can find anything.

Last edited 14 months ago by Marventus (previous) (diff)
  • Cc Whissi added
  • Version changed from 3.2.1 to 3.3.2

Is anybody working on this? The current release (3.3.2) is still affected.

  • Version changed from 3.3.2 to 3.2.1

The version tag is used for when the issue was introduced, not the most recent version it occurs in.

  • Version changed from 3.2.1 to 3.4

hello,

i cant find this line in version 3.4 and i have same issue...

Edit:
I have it i was looking in wp-includes/nav-menu.php

Last edited 11 months ago by dmaras (previous) (diff)
  • Version changed from 3.4 to 3.2.1

Version number indicates when the bug was initially introduced/reported.

#23286 was marked as a duplicate.

  • Owner Andrew Smith deleted
  • Status changed from new to reviewing
  • Cc marc@… added
  • Severity changed from major to blocker

When is this ticket going to be resolved? is there a patch? This is core functionality keeping my project from launching which is over 18months old. not cool. I can put in pages manually but my client cant manage them and as it turns out they have a very deep sitemap to place in the menu's section.

so again.. when is this to be resolved?

  • Severity changed from blocker to major

@energy0m: the issue will be resolved when... someone takes the time to resolve it. It seems Sergey is looking into it, but if you are in a rush, I suggest you contact him and - here's a crazy idea! - offer him to help. In the meantime, I can only suggest you take a chill pill and read up on what Open Source is all about: http://en.wikipedia.org/wiki/Open_source.

How can I help him when I don't know enough about PHP to resolve the problem?

I'm not actually looking into it yet, I've just removed the previous owner so that someone else could take over this ticket. Feel free to submit a patch.

This is essentially a visual bug - the hierarchy is not actually altered, and since nav menus specifically do not rely on the page hierarchy, nothing is broken beyond the visual. Yes, it is a bug and yes, it is frustrating, but it shouldn't be something that holds up a launch.

Note: See TracTickets for help on using tickets.