Quickedit on Spam Comments adds approve and unapprove

[hebbet]

repro:

Get a spam

click on quick edit

hit update comment

see attached screenshot

(top: normal look - bottom: after updating comment)

Not sure if that is by design, but it looks a little bit strange

Confirmed.

Not sure if that is by design, but it looks a little bit strange.

No, it makes no sense.

The problem is, that $comment_status is NULL, which is needed for this if clause.

In admin-ajax.php line 730 $comment_status will be defined but it isn't global.

Perhaps the bug is having Quick Edit on spam. This makes no sense :) If a comment is not spam you should mark it as such before editing. If it is... why would you edit it?

i use antispam bee (AB) and one of its features is adding a notice why it was added to spam. Like "[MARKED AS SPAM BY ANTISPAM BEE | CSS Hack]"

Another option is, that AB marks all non-german or non-english comments als spam. for that it uses google translate and sometimes it is wrong.

so i remove the notice with quick edit

Replying to hebbet:

Then your workflow for false positives (ham marked as spam) should be:

• Unspam.
• Edit the comment.

I don't think that the bug is to have Quick Edit on spam comments, it's also available for unapproved comments.

The bug exists since the new list table API.

Replying to ocean90:

IMHO spam comments are very similar to trashed comments. The only difference is that they were trashed automatically by a plugin or by matching a word, number of URLs, etc.

Unapproved comments are "undecided". That's why we have Edit and Approve as a combined editing action for them. This happens often in the workflow.

We should either extend the Edit and Approve to spam comments or completely remove editing there.

IMO spam comments are very similar to unapproved comments. There aren't trashed, they only get as status spam. So I know it from most of the plugins. I must decide if it's really a spam comment or not.

If they are trashed automatically then no Quick Edit is possible, that's fine.

+1 for Edit and Approve ( or Unspam)

I would be down for removing Quick Edit from Spam. Making a clear distinction between spam and trash or not-yet-approved helps less savvy users. And if it's something that is to be edited, then it can be marked Not Spam and still left in moderation or put in trash.

Removes Edit+Quick Edit from Spam'd posts

Attached patch removes Edit+Quick Edit from posts in Spam

So both patches here need to go in?

Updated patch to reflect duck_'s suggestions in IRC.

The added error message in wp-admin/comment.php could use a check/suggestions, since I was unsure how to phrase marking a comment as "not spam", while still keeping the same basic structure as the error for editing Trash'd messages.

Remove nested if & add check for editcomment/spam in wp-admin/comment.php

Tested & refreshed patch.

In [19296]:

Don't show edit links for spam comments. Props DH-Shredder. fixes #18340

Related: #19977

In [19856]:

Allow comment.php?action=editcomment to be accessible for a comment that is spam. props josephscott, fixes #19977, see #18340.