get_bookmarks() indefinitely caches randomly ordered results

[prettyboymp]

The get_bookmarks() function caches the results of all requests to the function in a single cache result so it can clear all the items when a new book mark is added. However, randomly ordered results shouldn't be cached indefinitely. This specifically affects the Links widget as it never refreshes when set to random order.

$orderby == 'rand()'

Shouldn't it be $orderby == 'rand' (without brackets)?

I'm not sure why you are re-implementing the expiration functionality that is already built into the caching system here.

If we need to use a different cache bucket and add expiration for RAND requests lets do that but don't implement a second level of expiration when we have one already.

Replying to SergeyBiryukov:

$orderby == 'rand()'

Shouldn't it be $orderby == 'rand' (without brackets)?

It's 'rand()' at that point because the $orderby variable is reused when building the query in the case statement.

Replying to westi:

I'm not sure why you are re-implementing the expiration functionality that is already built into the caching system here.

If we need to use a different cache bucket and add expiration for RAND requests lets do that but don't implement a second level of expiration when we have one already.

The problem with creating a new cache bucket is that you can't purge it automatically after modifying the bookmarks.

Replying to prettyboymp:

Replying to westi:

I'm not sure why you are re-implementing the expiration functionality that is already built into the caching system here.

If we need to use a different cache bucket and add expiration for RAND requests lets do that but don't implement a second level of expiration when we have one already.

The problem with creating a new cache bucket is that you can't purge it automatically after modifying the bookmarks.

Yes, but if it has a shortish expiration which is what you are suggesting here to deal with the RAND issue then that doesn't really matter.

switching to separate cache with shorter cache timeout