Opened 21 months ago
Closed 13 months ago
#18544 closed enhancement (fixed)
Remove wp-register.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | General | Version: | 3.3 |
| Severity: | trivial | Keywords: | has-patch commit |
| Cc: |
Description
added spacing to wp-register.php to match Codex Coding Standards for brackets
Attachments (3)
Change History (17)
christopherross — 21 months ago
- Keywords has-patch added
- Type changed from defect (bug) to enhancement
comment:2
SergeyBiryukov — 21 months ago
- Milestone changed from Awaiting Review to 3.3
- Summary changed from Spacing fixed in WP-Register.php to Remove wp-register.php
Actually, I think we could probably remove wp-register.php the way we removed the feed files.
comment:4
SergeyBiryukov — 21 months ago
18544.patch removes wp-register.php and performs canonical redirect to the appropriate place.
Needs bumping the db version on commit to regenerate rewrite rules.
SergeyBiryukov — 21 months ago
comment:5
SergeyBiryukov — 21 months ago
Should we add it to $_old_files to be removed on upgrade? We didn't do that for the feed files to prevent possible breakage in case of a lame use.
- Milestone changed from 3.3 to Future Release
Punting enhancements from 3.3.
comment:7
SergeyBiryukov — 17 months ago
- Milestone changed from Future Release to 3.4
Related: #19798
Can't get this to work. Not sure what happened, but the redirect isn't working for the feed files either.
SergeyBiryukov — 13 months ago
The redirect from wp-register.php to wp-login.php?action=register seems to work fine on my install (after applying the patch and flushing rewrite rules, which, according to admin.php, happens on DB upgrade). The redirect for the feed files works as well.
Refreshed the patch.
comment:11
follow-up:
↓ 12
christopherross — 13 months ago
@SergeyBiryukov / @Nacin would it be possible to remove the wp-pass.php file using the same approach? Chris
if ( 'wp-pass.php' == basename( $redirect['path'] ) ) {
// 10 days
setcookie('wp-postpass_' . COOKIEHASH, stripslashes( $_POST['post_password'] ), time() + 864000, COOKIEPATH);
wp_safe_redirect(wp_get_referer());
die();
}
comment:12
in reply to:
↑ 11
SergeyBiryukov — 13 months ago
Replying to christopherross:
would it be possible to remove the wp-pass.php file using the same approach?
wp-pass.php is already removed in #19798.
oops, my bad :)
I didn't notice #19798.
comment:14
nacin — 13 months ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In [20596]:

http://wpdevel.wordpress.com/2011/03/23/code-refactoring/
There was a number of code cleanup tickets like #17997, and the consensus was that coding style fixes should be a result of more substantial changes than just improving readability.