Opened 21 months ago
Closed 20 months ago
#18568 closed defect (bug) (fixed)
Post title field should be hidden in DFW if not listed in "supports" in post type registration.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | General | Version: | 3.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | nacin |
Description
As it is, if you create a custom post type, and don't list "title" in the "supports" list, then you won't have a title field in the normal editor (as it should be), but when you click the full screen editor, the title field is displayed. This goes for the editor textarea as well.
The diff file adds the post_type_supports check that the default editor.
Attachments (2)
Change History (8)
jtsternberg — 21 months ago
comment:1
jtsternberg — 21 months ago
- Milestone changed from Awaiting Review to 3.3
It would be better to remove the fields all together rather than via CSS.
jtsternberg — 21 months ago
comment:3
jtsternberg — 21 months ago
I agree, but the new attached diff is the best I can do. wp-fullscreen.dev.js requires the #wp-fullscreen-title id (see line 306 of wp-fullscreen.dev.js) or the full-screen button will not initiate full-screen mode. I am not a js wizard, so if there's a better way, please enlighten me.
- Owner changed from jtsternberg to azaozz
- Status changed from new to assigned
- Component changed from UI to General
- Summary changed from Full Screen Editor Fields should be hidden if not listed in "supports" in post type registration. to Post title field should be hidden in DFW if not listed in "supports" in post type registration.
I stand corrected... if the editor areas is not listed in "supports" than the full screen button isn't even available, but the patch addresses the title issue.