Opened 21 months ago

Closed 16 months ago

#18683 closed task (blessed) (fixed)

XMLRPC wp.getMediaLibrary doesn't return attachment ids

Reported by: skithund Owned by: josephscott
Priority: normal Milestone: 3.4
Component: XML-RPC Version: 3.2.1
Severity: normal Keywords: has-patch commit dev-reviewed
Cc: oc@…, ercoli@…

Description

XMLRPC wp.getMediaLibrary method loops attachments through wp_getMediaItem function, which doesn't return attachment ids.

Attachments (1)

getmediaitem.diff​ (496 bytes) - added by skithund 21 months ago.
Return attachment_id in wp_getMediaItem

Download all attachments as: .zip

Change History (9)

skithund — 21 months ago

Return attachment_id in wp_getMediaItem

comment:1   ocollet — 19 months ago

  • Cc oc@… added

comment:2   josephscott — 17 months ago

  • Keywords commit added

Looks good to me, I'd be fine committing this.

comment:3   SergeyBiryukov — 17 months ago

  • Milestone changed from Awaiting Review to 3.4

comment:4   ericmann — 16 months ago

+1 On returning IDs. I know of at least 2 XMLRPC clients that would benefit from this addition.

comment:5   daniloercoli — 16 months ago

  • Cc ercoli@… added

comment:6   josephscott — 16 months ago

  • Type changed from enhancement to task (blessed)

comment:7   westi — 16 months ago

  • Keywords dev-reviewed added
  • Owner set to josephscott
  • Status changed from new to assigned

Can we make this patch ensure that the IDs are returned as strings not ints so that we have no chance of returning invalid data in an XML-RPC response - our IDs go to values bigger than the spec for integers in xml-rpc.

With that change this should be fine to commit.

comment:8   josephscott — 16 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [19885]:

Provide the attachment_id of a media item in the XML-RPC call wp.getMediaItem.

Props skithund
Fixes #18683

Note: See TracTickets for help on using tickets.