Ticket #18683 (closed task (blessed): fixed)

Opened 5 months ago

Last modified 2 weeks ago

XMLRPC wp.getMediaLibrary doesn't return attachment ids

Reported by: skithund Owned by: josephscott
Priority: normal Milestone: 3.4
Component: XML-RPC Version: 3.2.1
Severity: normal Keywords: has-patch commit dev-reviewed
Cc: oc@…, ercoli@…

Description

XMLRPC wp.getMediaLibrary method loops attachments through wp_getMediaItem function, which doesn't return attachment ids.

Attachments

getmediaitem.diff Download (496 bytes) - added by skithund 5 months ago.
Return attachment_id in wp_getMediaItem

Change History

skithund — 5 months ago

Return attachment_id in wp_getMediaItem

comment:1   ocollet — 4 months ago

  • Cc oc@… added

comment:2   josephscott — 8 weeks ago

  • Keywords commit added

Looks good to me, I'd be fine committing this.

comment:3   SergeyBiryukov — 7 weeks ago

  • Milestone changed from Awaiting Review to 3.4

comment:4   ericmann — 5 weeks ago

+1 On returning IDs. I know of at least 2 XMLRPC clients that would benefit from this addition.

comment:5   daniloercoli — 4 weeks ago

  • Cc ercoli@… added

comment:6   josephscott — 3 weeks ago

  • Type changed from enhancement to task (blessed)

comment:7   westi — 2 weeks ago

  • Keywords dev-reviewed added
  • Owner set to josephscott
  • Status changed from new to assigned

Can we make this patch ensure that the IDs are returned as strings not ints so that we have no chance of returning invalid data in an XML-RPC response - our IDs go to values bigger than the spec for integers in xml-rpc.

With that change this should be fine to commit.

comment:8   josephscott — 2 weeks ago

  • Status changed from assigned to closed
  • Resolution set to fixed

In [19885]:

Provide the attachment_id of a media item in the XML-RPC call wp.getMediaItem.

Props skithund
Fixes #18683

Note: See TracTickets for help on using tickets.