Opened 20 months ago

Closed 20 months ago

#18712 closed defect (bug) (fixed)

Database upgrade script can kill POST requests

Reported by: dd32 Owned by: dd32
Priority: normal Milestone: 3.3
Component: Administration Version:
Severity: normal Keywords:
Cc:

Description

If a site upgrade is done whilst a user is active, a database upgrade may be triggered on a POST request.

The result of this is that the POST data is lost, and the user may be redirected to a page without any query vars (as they were POST vars, not GET).

Since the Database upgrades are upgrades which are generally not necessary to be performed at that exact instant, we can avoid running the upgrade on POST requests with data (such as the Save Draft action), and let the following GET have the honours (as most POST requests will perform a redirect to a GET afterwards).

Related: #7965 - Database upgrade complete message should be an admin notice

As reported by Matt

Change History (1)

comment:1   dd32 — 20 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In [18731]:

Don't trigger Database Upgrades for POST requests with a body. Fixes #18712

Note: See TracTickets for help on using tickets.