Notice in /wp-admin/upload.php

[juliobox]

Hello

wp-admin/upload.php
line 25 & 28 &30, the $post_ids var is set but only in IF statments.
so if none of this IF is TRUE we got "Notice: Undefined variable: post_ids in /wp-admin/upload.php on line XXX"
lines affected : 93, 100, 103, 110, 113, 120.

How to reproduce :

• go to ​http://website.com/wp-admin/upload.php
• in "bulk actions" choose "delete permanently" without checking any checkbox
• click "Apply"

-> Notices !

In wp-admin/edit.php and elsewhere there is a check for empty bulk edits which just redirects back to the page you were on - I think we should be doing the same here.

Redirect back to upload.php if no posts were selected for bulk actions

Won't that interfere with the find_detached and attach actions?

Replying to ryan:

Won't that interfere with the find_detached and attach actions?

Indeed. We only need to check for $post_ids where it's actually used. Done in 18774.patch​.

In [18876]:

Avoid notice when performing bulk actions with now rows selected. Props SergeyBiryukov. fixes #18774