Twentyeleven templates do not properly call the loop

[jfarthing84]

Is there any particular reason that twentyeleven does not use a proper loop? Many (if not all) of the templates use

the_post()

rather than

if ( have_posts() ) : the_post();

thus defining $wp_query->in_the_loop as always true.

Some templates do indeed have this problem.

This is something we fixed with Twenty Ten, so it's rather annoying it got through again.

image.php, page.php, showcase.php, and sidebar-page.php are all affected. single.php is not, in particular.

Previously: #13279.

I uploaded 18794.diff which seems to fix this issue in all templates with partial loops. Please let me know if I missed anything.

This looks good to me. Twenty Eleven on WP.com is already running the same code submitted by mfields.

In [19379]:

TwentyEleven: Always call the loop properly in all template files rather than just calling the_post(). Fixes #18794 props mfields.