thickbox.css needs display:none

[OoroonBai]

In thickbox.css display:none was replaced by visibility:hidden (line 52). The thickbox will not be displayed if there is no property 'display', because thickbox checks the property 'display' (line 208 in thickbox.js).
If you use e.g. tb_show in a javascript, it will not show the thickbox.

I can confirm this. Have been wondering why my plugin that calls tb_show() through its own call does not work with trunk, but with 3.2.1.
Relevant change seems to have been introduced in [18482].

Also noticed in #18815

18796.patch​ restores display: none.

But then I've noticed there's a small delay before #TB_window fully opens, leading to overlapping for some part of a second (see the screenshot).

18796.2.patch​ switches the remaining display references to visibility. Looks like the delay is not happening in that case.

Replying to SergeyBiryukov:

But then I've noticed there's a small delay before #TB_window fully opens, leading to overlapping for some part of a second (see the screenshot).

18796.2.patch​ switches the remaining display references to visibility. Looks like the delay is not happening in that case.

Do you try '.show()' instead of 'viibility' or 'display'? Maybe this fix your problem with overlapping.

thickbox.18796.patch​ restore 'display: none' and replace '.css('display', 'block')' with '.show()'.

Still see the overlapping in Firefox 7 with thickbox.18796.patch​. According to ​jQuery docs, .show() just sets display: block internally.

Also, there's a typo in thickbox.css, should be display: none.

This was changed because the uploader had problems initializing in a hidden iframe in some browsers. Seems 18796.2.patch is the proper solution here and the overlapping can probably be solved with css.

With 18796.2.patch, there's no overlapping, so should be fine as is.

I tested 18796.2.patch with some of my plugins. All work fine. I think we can close the ticket.

Tickets are closed when a commit is made to the WordPress trunk.

In [18848]:

Fix thickbox (again!), props SergeyBiryukov, fixes #18796