wp_lostpassword_url should be applied instead of using site_url

[markoheijnen]

At this moment there are several places where the following code is been used:

site_url('wp-login.php?action=lostpassword', 'login')

It would be better to change that to wp_lostpassword_url. I created a patch what does that. Only in wp-login I left two lines open: form and error handling.

I also changed wp_lostpassword_url so it can used within networks. The if/else statement can be removed when always using network_site_url. Also added some spacing.

Related ticket is: #9932

First version of the patch

I didn't know we had wp_lostpassword_url(). Not using our own API, that's lame.

We can always use network_site_url(), no need for an if statement. If not multisite, it simply calls site_url().

I also didn't knew but needed to overwrite it to send it to a page instead. That is also why I left two line open in wp-login.php

Update the patch to always use network_site_url()

In [19027]:

Use wp_lostpassword_url() instead of site_url(wp-login...). Update wp_lostpassword_url() to use network_site_url(). props markoheijnen, fixes #18808.

Replying to nacin:

I didn't know we had wp_lostpassword_url().

The wp_lostpassword_url() functions exists since 2.8, check #9932 ticket.