Opened 20 months ago

Closed 4 months ago

#18840 closed enhancement (duplicate)

get_pages query optimization for inclusions/exclusions

Reported by: 5ubliminal Owned by:
Priority: normal Milestone:
Component: Performance Version: 3.3
Severity: normal Keywords: has-patch 3.4-early
Cc:

Description

Turned ID <> 1, ID <> 2, ... into ID IN (1, 2, ...).
Removed some redundant ->prepare as the IDs are already int-cast, hence improved performance.

Concatenation is done once also, not once for each excluded ID.
Shortened the query a lot and gained 20% in speed compared to old method (on about 25 excluded pages from about 40).

Attachments (1)

get_pages_inexclusions_sql_optimisation.patch​ (1.3 KB) - added by 5ubliminal 20 months ago.

Download all attachments as: .zip

Change History (3)

5ubliminal — 20 months ago

comment:1   nacin — 19 months ago

  • Keywords has-patch 3.4-early added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from task (blessed) to enhancement

Looks good. We probably have a few other areas in core that results in similar SQL construction as well.

comment:2   wonderboymusic — 4 months ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #22074.

My patch is newer, does the same-ish thing

Note: See TracTickets for help on using tickets.