WordPress.org

Make WordPress Core

Opened 21 months ago

Closed 21 months ago

#18867 closed defect (bug) (fixed)

Only variables should be assigned by reference

Reported by: arena Owned by: arena
Priority: normal Milestone: 3.3
Component: Administration Version: 3.3
Severity: trivial Keywords: has-patch commit
Cc:

Description

Only variables should be assigned by reference in D:\webserver\htdocs\wordpress\wp-includes\capabilities.php at line 667

Attachments (1)

#18867.patch​ (631 bytes) - added by arena 21 months ago.

Download all attachments as: .zip

Change History (5)

arena — 21 months ago

comment:1 scribu — 21 months ago

  • Milestone changed from Awaiting Review to 3.3

comment:2 scribu — 21 months ago

  • Keywords commit added

comment:3 nacin — 21 months ago

The fix here would be to return $null = null, rather than null, in WP_Roles::get_roles().

Of course, the argument could be made we no longer need references here.

comment:4 ryan — 21 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In [18956]:

Avoid 'Only variables should be assigned by reference' warning. Props arena. fixes #18867

Note: See TracTickets for help on using tickets.