Opened 20 months ago
Closed 20 months ago
#18881 closed defect (bug) (fixed)
"Scale images to match ..." in "/wp-admin/includes/media.php"
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | Media | Version: | 3.3 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
That sentence needs a better style. It's nearly impossible to create a good translation (meaning: it should sound right) because the word order in my native language is different.
Attachments (5)
Change History (13)
- Component changed from General to Media
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 3.3
- Type changed from enhancement to defect (bug)
- Version set to 3.3
We need also a capability check here, don't show the link if the user can't manage_options.
SergeyBiryukov — 20 months ago
SergeyBiryukov — 20 months ago
comment:2
SergeyBiryukov — 20 months ago
- Keywords has-patch added; needs-patch removed
We can also probably merge the strings into one.
Shouldn't it be "media settings" rather than "image options"?
Replying to ocean90:
We need also a capability check here, don't show the link if the user can't manage_options.
Actually that link can be removed. Put it there as during testing the users were wondering where the 1024x1024 thing came from. Perhaps we can think of a better text/explanation that won't need the link.
Do we need translators comment? See 18881.3.patch.
It's OK. It looks a bit strange because of '%1$simage options%2$s' but it's better to translate now. I'm okay with it.
comment:7
SergeyBiryukov — 20 months ago
+1 for 18881.4.patch.

media.php.diff