Opened 20 months ago

Closed 18 months ago

Last modified 18 months ago

#18891 closed defect (bug) (fixed)

wp_error does not recognize when a custom post type does not support excerpts

Reported by: ZaneMatthew Owned by:
Priority: normal Milestone: 3.3
Component: General Version: 3.2.1
Severity: normal Keywords: has-patch
Cc:

Description

wp_error does not take into consideration if a custom post type does not support excerpts.

Steps to reproduce:

  1. Create a custom post type that does NOT support excerpts.
  2. Use wp_insert_post to insert the post
  3. print_r your error message and you'll see that wp_error is returns:

"Content, title, and excerpt are empty."

It should not mention excerpts being empty as the custom post type does not even support them.

Attachments (1)

18891.patch (1.0 KB) - added by SergeyBiryukov 20 months ago.

Download all attachments as: .zip

Change History (8)

Is this a duplicate of #18713?

  • Resolution set to duplicate
  • Status changed from new to closed

Yes it is, sorry.

  • Resolution duplicate deleted
  • Status changed from closed to reopened

Related, but doesn't look like an exact duplicate to me.

#18713 is about wp_insert_post() bailing too early, while this ticket is about more correct error message.

Version 0, edited 20 months ago by SergeyBiryukov (next)
  • Keywords has-patch added

comment:5 follow-up: ↓ 6   SergeyBiryukov18 months ago

  • Milestone changed from Awaiting Review to 3.3
  • Resolution set to fixed
  • Status changed from reopened to closed

comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7   johnbillion18 months ago

Replying to SergeyBiryukov:

[19305]

Doesn't this change mean that whole check now gets skipped if one or more of those fields aren't supported by the post type?

comment:7 in reply to: ↑ 6   nacin18 months ago

Replying to johnbillion:

Replying to SergeyBiryukov:

[19305]

Doesn't this change mean that whole check now gets skipped if one or more of those fields aren't supported by the post type?

Yes. It basically means this check no longer applies to any customized post types.

Note: See TracTickets for help on using tickets.