WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 5 weeks ago

#18900 new enhancement

Add a few more hide-if-no-js classes

Reported by: johnbillion Owned by:
Priority: normal Milestone: Awaiting Review
Component: Accessibility Version: 3.3
Severity: minor Keywords: has-patch
Cc: xoodrew@…

Description

There are a few elements to which we could add the hide-if-no-js class, as their functionality or setting relies on JavaScript being available.

Attachments (6)

18900.patch (3.0 KB) - added by johnbillion 21 months ago.
18900.2.patch (570 bytes) - added by johnbillion 13 months ago.
18900-header-bg.diff (1.6 KB) - added by DrewAPicture 9 months ago.
Choose from Media Library links
18900-header-bg.2.diff (1.8 KB) - added by DrewAPicture 9 months ago.
Simplifies the UI, no empty space if no-js
18900-header-bg.3.diff (1.7 KB) - added by DrewAPicture 9 months ago.
Only introduce one new string, not two.
18900-header-bg.3.1.diff (2.4 KB) - added by DrewAPicture 9 months ago.
Combines with 18900.2.patch

Download all attachments as: .zip

Change History (14)

johnbillion21 months ago

comment:1 johnbillion21 months ago

  • Keywords has-patch added

Patch. Hides the Press This link and two user settings which need JavaScript to function.

comment:2 nacin19 months ago

Does Press This actually need JS? Many probably selectively disable JavaScript at the domain level, rather than the browser level. I'm thinking that a browser bookmarklet may still work in the case of NoScript/AdBlock, etc.

comment:3 azaozz19 months ago

The current implementation of Press This needs JS enabled for both domains, the WP install and the visited site. However if NoScript is used it's trivial to enable JS temporarily and use Press This.

johnbillion13 months ago

comment:4 johnbillion13 months ago

Attached patch adds 'hide-if-no-js' class to the "Edit Image" button when viewing a media item, as image editing required JS.

DrewAPicture9 months ago

Choose from Media Library links

comment:6 DrewAPicture9 months ago

  • Cc xoodrew@… added

18900-header-bg.diff hides the 'Choose Image' button (from Media Library) on Custom Header & Custom Background pages. I left the direction label and added a "You need javascript to do this" message.

Version 0, edited 9 months ago by DrewAPicture (next)

DrewAPicture9 months ago

Simplifies the UI, no empty space if no-js

comment:7 DrewAPicture9 months ago

18900-header-bg.2.diff Simplifies the UI, removes the entire <p> block if no-js and displays message instead: http://cl.ly/image/2a1C1u0L1J2A

Last edited 9 months ago by DrewAPicture (previous) (diff)

DrewAPicture9 months ago

Only introduce one new string, not two.

DrewAPicture9 months ago

Combines with 18900.2.patch

comment:8 SergeyBiryukov5 weeks ago

#24321 was marked as a duplicate.

Note: See TracTickets for help on using tickets.