Opened 20 months ago

Last modified 10 days ago

#18900 new enhancement

Add a few more hide-if-no-js classes

Reported by: johnbillion Owned by:
Priority: normal Milestone: Awaiting Review
Component: Accessibility Version: 3.3
Severity: minor Keywords: has-patch
Cc: xoodrew@…

Description

There are a few elements to which we could add the hide-if-no-js class, as their functionality or setting relies on JavaScript being available.

Attachments (6)

18900.patch (3.0 KB) - added by johnbillion 20 months ago.
18900.2.patch (570 bytes) - added by johnbillion 12 months ago.
18900-header-bg.diff (1.6 KB) - added by DrewAPicture 8 months ago.
Choose from Media Library links
18900-header-bg.2.diff (1.8 KB) - added by DrewAPicture 8 months ago.
Simplifies the UI, no empty space if no-js
18900-header-bg.3.diff (1.7 KB) - added by DrewAPicture 8 months ago.
Only introduce one new string, not two.
18900-header-bg.3.1.diff (2.4 KB) - added by DrewAPicture 8 months ago.
Combines with 18900.2.patch

Download all attachments as: .zip

Change History (14)

  • Keywords has-patch added

Patch. Hides the Press This link and two user settings which need JavaScript to function.

Does Press This actually need JS? Many probably selectively disable JavaScript at the domain level, rather than the browser level. I'm thinking that a browser bookmarklet may still work in the case of NoScript/AdBlock, etc.

The current implementation of Press This needs JS enabled for both domains, the WP install and the visited site. However if NoScript is used it's trivial to enable JS temporarily and use Press This.

Attached patch adds 'hide-if-no-js' class to the "Edit Image" button when viewing a media item, as image editing required JS.

Choose from Media Library links

  • Cc xoodrew@… added

18900-header-bg.diff hides the 'Choose Image' button (from Media Library) on Custom Header & Custom Background pages. I left the direction label and added a "You need javascript to do this" message: http://cl.ly/image/3A3l2H420g40

Last edited 8 months ago by DrewAPicture (previous) (diff)

Simplifies the UI, no empty space if no-js

18900-header-bg.2.diff Simplifies the UI, removes the entire <p> block if no-js and displays message instead.

Version 0, edited 8 months ago by DrewAPicture (next)

Only introduce one new string, not two.

Combines with 18900.2.patch

#24321 was marked as a duplicate.

Note: See TracTickets for help on using tickets.