Opened 20 months ago
Last modified 7 days ago
#18900 new enhancement
Add a few more hide-if-no-js classes
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Accessibility | Version: | 3.3 |
| Severity: | minor | Keywords: | has-patch |
| Cc: | xoodrew@… |
Description
There are a few elements to which we could add the hide-if-no-js class, as their functionality or setting relies on JavaScript being available.
Attachments (6)
Change History (14)
johnbillion — 20 months ago
comment:1
johnbillion — 20 months ago
- Keywords has-patch added
Does Press This actually need JS? Many probably selectively disable JavaScript at the domain level, rather than the browser level. I'm thinking that a browser bookmarklet may still work in the case of NoScript/AdBlock, etc.
The current implementation of Press This needs JS enabled for both domains, the WP install and the visited site. However if NoScript is used it's trivial to enable JS temporarily and use Press This.
johnbillion — 12 months ago
comment:4
johnbillion — 12 months ago
Attached patch adds 'hide-if-no-js' class to the "Edit Image" button when viewing a media item, as image editing required JS.
comment:5
SergeyBiryukov — 8 months ago
comment:6
DrewAPicture — 8 months ago
- Cc xoodrew@… added
18900-header-bg.diff hides the 'Choose Image' button (from Media Library) on Custom Header & Custom Background pages. I left the direction label and added a "You need javascript to do this" message: http://cl.ly/image/3A3l2H420g40
comment:7
DrewAPicture — 8 months ago
18900-header-bg.2.diff Simplifies the UI, removes the entire <p> block if no-js and displays message instead: http://cl.ly/image/2a1C1u0L1J2A
comment:8
SergeyBiryukov — 7 days ago
#24321 was marked as a duplicate.

Patch. Hides the Press This link and two user settings which need JavaScript to function.