Opened 20 months ago

Closed 14 months ago

Last modified 14 months ago

#18927 closed enhancement (wontfix)

is_email() check for string first

Reported by: jkudish Owned by:
Priority: normal Milestone:
Component: Formatting Version: 3.3
Severity: minor Keywords: has-patch close
Cc: kpayne@…

Description

Currently, if you pass anything else than a string to is_email() it will generate a fatal error because strlen() expects a string. The proposed patch checks for is_string() first.

Attachments (1)

18927.diff​ (536 bytes) - added by jkudish 20 months ago.

Download all attachments as: .zip

Change History (5)

jkudish — 20 months ago

comment:1   kurtpayne — 20 months ago

  • Cc kpayne@… added

Related #17433.

comment:2 follow-up: ↓ 3   nacin — 18 months ago

  • Keywords close added

Why? is_email() should only get a string. Passing it something that isn't scalar is a developer error. I'd rather the developer see a fatal error than a suppressed false.

comment:3 in reply to: ↑ 2   jkudish — 14 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

Replying to nacin:

Why? is_email() should only get a string. Passing it something that isn't scalar is a developer error. I'd rather the developer see a fatal error than a suppressed false.

fair.

comment:4   helenyhou — 14 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.