Opened 19 months ago

Closed 19 months ago

#18994 closed defect (bug) (fixed)

Upload text adjustments

Reported by: SergeyBiryukov Owned by:
Priority: normal Milestone: 3.3
Component: Media Version: 3.3
Severity: normal Keywords: needs-patch
Cc:

Description

Replying to jane:

Can we drop the "or" to be small and on line with Select Files button, and put cancel a p space below the select?

Attachments (4)

18994.break-line.patch​ (1.2 KB) - added by SergeyBiryukov 19 months ago.
Original patch by ocean90
18994.break-line.2.patch​ (1.2 KB) - added by SergeyBiryukov 19 months ago.
With %s placeholder
18994.break-line.3.patch​ (1.2 KB) - added by SergeyBiryukov 19 months ago.
With two %s placeholders
18994.break-line.4.patch​ (1.2 KB) - added by SergeyBiryukov 19 months ago.
Refreshed

Download all attachments as: .zip

Change History (10)

SergeyBiryukov — 19 months ago

Original patch by ocean90

SergeyBiryukov — 19 months ago

With %s placeholder

SergeyBiryukov — 19 months ago

With two %s placeholders

SergeyBiryukov — 19 months ago

Refreshed

comment:2   nacin — 19 months ago

  • Keywords ui-feedback needs-refresh added

Patch is stale. I hacked in the code and it looks okay. (Needed to add a hyphen to the drag-drop-info class for styling to work.)

With "Cancel" on its own line: ​http://cl.ly/3D2S182O0V0M0o183e0U

What I think looks better is with "Cancel" next to "Select Files": ​http://cl.ly/2U1Z0l1n2n1U0j0g451z

Leaving this one for Jane.

comment:3   SergeyBiryukov — 19 months ago

  • Keywords needs-refresh removed

comment:4   ocean90 — 19 months ago

Cancel button is gone, how should it look now? Jane?

comment:5   ocean90 — 19 months ago

  • Keywords needs-patch added; has-patch ui-feedback removed

From IRC chat:

Jane_: if r could be on its own line between drop files here and the button, that would be good

Jane_: and smaller text

Jane_: (for the or, not for drop files here)

ocean90: like G+? ​http://cl.ly/BYCX

Jane_: yes

comment:6   ocean90 — 19 months ago

  • Resolution set to fixed
  • Status changed from new to closed

[19177]

Note: See TracTickets for help on using tickets.