RTL fixes for 3.3

[yoavf]

It's time for a main 3.3 RTL ticket - I know it's usually better to split things up (see {38} ) but I think that at this point it's better to consolidate issues so we can all work on this together.

The attached patch refreshes admin-bar-rtl completely to account for 3.3 changes, fixes a bug in the uploader RTL css, and with the admin footer.

The patch also consolidates fixes for:

• #18000
• #17988 (co-props SergeyBiryukov)
• #19006 (props rosshanney)

In [19080]:

RTL fixes for 3.3, props yoavf SergeyBiryukov rosshanney, see #19042 fixes #18000, fixes #17988, fixes #19006

I've noticed a few RTL issues with the admin bar in Internet Explorer. For example, in IE9, the white update count circle doesn't appear correctly and the little downward pointing arrows don't appear at all (or appear in the wrong place with the patch proposed in #19086).

Also, in IE7, everything in the admin bar disappears altogether on hover.

Is it best to create separate tickets for these issues, or just discuss them here?

Replying to rosshanney:

The bubble looks fine to me:

and the arrows are most likely going to be removed (they were meant to appear on hover if the menus needed clicks to open).

I'm referring to the available update count notification (the white circle), not the comments bubble.

Replying to azaozz:

and the arrows are most likely going to be removed (they were meant to appear on hover if the menus needed clicks to open).

Ah, I see. Fair enough!

19042.help-and-screen-options.patch​ contains RTL adjustments for Help and Screen options since [19131].

19042.toggle-arrow-cleanup.patch​ cleans up unused .toggle-arrow class styles.

Being in RTL sections of colors-*.css files, they:

1. Don't have .rtl prefix.
2. Are overridden by editor-buttons.css.

Replying to SergeyBiryukov:

2. Are overridden by editor-buttons.css.

Editor-buttons is supposed to hold all styling for outside the editors (mostly buttons and toolbars) as they can be used on the front end now. For the blue theme and RTL in the admin we could use a bit more specific selectors, i.e. prefix the selectors by one of the container classes/IDs like #wpcontent, #wpbody, .wrap, etc.

In [19147]:

Help and Screen Options RTL adjustments, props SergeyBiryukov, see #19042

In [19148]:

Remove unused .toggle-arrow styling, props SergeyBiryukov, see #19042

19042.welcome-panel.patch​ contains RTL adjustments for Welcome Panel as per [19163].

The plugin update message on the plugins screen is a little out of place.

Please see 19042.plugin-update-message.diff​.

The collapse icon points the wrong way when the admin menu is collapsed (.folded). Also, the shadows on admin menu flyouts don't seem quite right.

Please see 19042.collapse-icon-and-submenu-shadows.diff​

The "Howdy" section of the admin bar no longer appears at the far left. I think caused by [19230].

Please see 19042.admin-bar-howdy-menu.diff​

Update for "Howdy" menu patch, after [19261] changes.

Another update for "Howdy" patch, after [19270].

In [19307]:

More RTL fixes, props rosshanney, see #19042

Fix for flyout jumpiness

Submenu flyout jumps on focus: ​http://cl.ly/0v0a3C1v1M3d3z0E3w1Y

19042.flyoutjump.diff should fix it.

When deactivating a plugin (and I'm not sure where else) the text alert reads .Plugin deactivated (sic)

Ignore my last bug report-image, I'm an idiot newb to RTL.

That being said, my latest patch on #18654 -- 18654.with-201-percent-more-rtl.diff -- also happens to fix the user menu in RTL. I'm cross-posting so it doesn't get lost in the shuffle somehow (thanks, jjj!)

Admin bar needs some RTL love.

#19293

admin-menu-rtl.patch​ will fix all RTL issues with the admin menu, includes the issue mentioned by helenyhou in comment:16.

In [19353]:

More RTL for the admin menu, props ocean90, see#19042

The progress bar shows a dark line at beginning. Only in thickbox media uploader.

In [19360]:

Remove old styling for rtl progress bar, see #19042

Help styling is broken: ​http://cl.ly/2C331K2P2t2M0C0q2K0n

Working on a patch.

Help tab

19042.helptabs.diff fixes help styling, probably broken in r19361.

In [19371]:

Help tabs RTL fixes, props helenyhou, see #19042

Please open new tickets for still existing RTL issues.

In [19446]:

Few more RTL and IE7 fixes, see #19042