Opened 19 months ago
Last modified 13 months ago
#19130 assigned defect (bug)
current wp-login.php call to wp_admin_css() bypasses its own filter
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | General | Version: | 2.6 |
| Severity: | normal | Keywords: | has-patch close |
| Cc: | 24-7@…, Ninos, Ego |
Description
The current situation in wp-login.php looks like the following:
wp_admin_css( 'login', true ); wp_admin_css( 'colors-fresh', true );
Looking at /wp-includes/general-template.php and wp_admin_css( $file = 'wp-admin', $force_echo = false ); tells that this bypasses the filter calls as the function returns if $force_echo is true. The filters are called after that. This doesn't make sense as the filter will never work this way. Changing wp_admin_css() is no option, so I suggest to change the calls to it in login_head.
Attachments (1)
Change History (9)
F J Kaiser — 19 months ago
comment:1
F J Kaiser — 19 months ago
- Cc 24-7@… added
- Keywords has-patch added
comment:2
F J Kaiser — 19 months ago
- Version set to 3.3
comment:3
F J Kaiser — 19 months ago
- Owner set to F J Kaiser
- Status changed from new to assigned
comment:5
in reply to:
↑ 4
F J Kaiser — 18 months ago
- Keywords close added
- Version changed from 3.2.1 to 2.6
Comment from nacin:
Core CSS files will get processed via WP_Styles, so the filter isn't very helpful anymore.
The filter wp_admin_css will never be fired for core files, no matter if $force_echo is true or false. If you use a custom file the filter can be used.
Behaviour introduced in #7011.
- Cc Ninos Ego added
- Version changed from 2.6 to 3.3.1
I hope in the next version you can fix this bug. Because I want to do all things with wordpress, and this issue is like a jail for me. I have got a custom login stylesheet. 80% of the code are !important atribute. Beyond my login page is not compatible with other browsers..

Duplicate of #14559?