Opened 19 months ago

Closed 17 months ago

#19157 closed enhancement (fixed)

Remove PHP4 compat from timer functions

Reported by: solarissmoke Owned by: nacin
Priority: normal Milestone: 3.4
Component: Performance Version: 3.3
Severity: minor Keywords: has-patch 3.4-early
Cc:

Description

The timer_start/stop functions are using microtime() in PHP4 compat mode, without the get_as_float argument. We can make them all much simpler, see patch. Also fixes some of the inline docs.

Attachments (1)

19157.diff​ (2.6 KB) - added by solarissmoke 19 months ago.
Use microtime() with get_as_float

Download all attachments as: .zip

Change History (5)

comment:1   solarissmoke — 19 months ago

  • Keywords has-patch added

solarissmoke — 19 months ago

Use microtime() with get_as_float

comment:2   nacin — 18 months ago

  • Keywords 3.4-early added
  • Milestone changed from Awaiting Review to Future Release

comment:3   nacin — 17 months ago

  • Milestone changed from Future Release to 3.4

comment:4   nacin — 17 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19611]:

Ask for a float from microtime() for timer_start(), timer_stop(). Clarify docs. props solarissmoke, fixes #19157.

Note: See TracTickets for help on using tickets.