Opened 19 months ago

Closed 18 months ago

Last modified 18 months ago

#19176 closed defect (bug) (fixed)

Tag auto-suggest doesn't work in Quick Edit for posts with no tags

Reported by: linuxologos Owned by: nacin
Priority: normal Milestone: 3.3
Component: Quick/Bulk Edit Version: 3.0
Severity: normal Keywords: has-patch
Cc:

Description

Try adding a tag to a post with No Tags on Posts screen through Quick Edit. The auto-suggest feature doesn't work.

Try the same with a post that already has at least one tag. Auto-suggest works fine.

This was introduced in WP 3.0 and affects WP 3.3 too.

Attachments (3)

19176.diff (1.0 KB) - added by solarissmoke 19 months ago.
Hook autouggest even if the textarea is empty to start with
19716.diff (757 bytes) - added by scottbasgaard 18 months ago.
19176v2.diff (944 bytes) - added by scottbasgaard 18 months ago.
Sorry for the filename typo in my first patch. Here's round 2 with support for post_tags and all other non heirarchy taxs.

Download all attachments as: .zip

Change History (16)

Hook autouggest even if the textarea is empty to start with

  • Keywords has-patch added

The current JS only binds the autosuggest if the textarea isn't empty t start with - I'm guessing this was a mistake.

19176.diff works for me.

Looks like it was just an oversight in [13535].

In [19204]:

Allow tags autosuggest to work in quick edit when there are no tags. props solarissmoke, see #19176.

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19205]:

Merge and update variable declarations. fixes #19176.

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Unfortunately tags autosuggest fixed in [19204] for Quick Edit doesn't work for Bulk Edit. It broke in WP 3.0 along with Quick Edit. Fixing may be related.

Not sure if there is more to this but it looks like the selector needed some updates.

  • Keywords has-patch added; needs-patch removed

19716.diff seems to fix the issue as far as post_tag taxonomy is concerned. Is it simple enough to support custom (non-hierarchical) taxonomies too? Quick Edit does. Bulk Edit does not yet.

Sorry for the filename typo in my first patch. Here's round 2 with support for post_tags and all other non heirarchy taxs.

Going with 19716.diff for now, as it is a straightforward fix for post tags in bulk edit.

Adding support for all flat taxonomies for all post types requires a bit more work, as evidenced by the first pass in 19176v2.diff. It would probably be better to iterate through $('.tags_input', rowData) and cherry pick the taxonomies from there. See how flat taxonomies are handled for quick edit (line ~183).

scottbasgaard, can you open a new ticket for this? We can handle it in 3.4.

  • Resolution set to fixed
  • Status changed from reopened to closed

Cool. Done #19392. :D

Note: See TracTickets for help on using tickets.