Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#19194 closed defect (bug) (fixed)

Fullscreen button in HTML mode is missing

Reported by: Ipstenu Owned by: azaozz
Priority: high Milestone: 3.3
Component: Editor Version: 3.3
Severity: critical Keywords:
Cc:

Description

WordPress 3.3-beta2-19181. The Fullscreen button for HTML mode in the post editor is missing. You can still get there by switching to visual, going full screen, and then back to HTML, but that's a really bad idea.

Change History (6)

comment:1   SergeyBiryukov — 19 months ago

  • Milestone changed from Awaiting Review to 3.3

comment:2 follow-up: ↓ 3   nacin — 19 months ago

  • Severity changed from normal to critical

Probably broken by [19172]?

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 6   duck_ — 19 months ago

Replying to nacin:

Probably broken by [19172]?

Yes.

buttons['fullscreen'] = new qt.FullscreenButton();

went missing from quicktags.js.

Also does _buttonsInit need to loop through theButtons right after looping through edButtons to build html string? Can't that be done whilst adding elements from edButtons to theButtons in the first loop?

comment:4   ryan — 19 months ago

  • Priority changed from normal to high

comment:5   azaozz — 19 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19215]:

Bring back the Fullscreen button in Quicktags, fixes #19194

comment:6 in reply to: ↑ 3   azaozz — 19 months ago

Replying to duck_:

The second loop was supposed to happen after theButtons were filtered but since we don't have proper filters in JS (yet), we can do that later.

Note: See TracTickets for help on using tickets.