Ticket #19249 (closed defect (bug): fixed)

Opened 3 months ago

Last modified 7 weeks ago

Fixing Walker Notice regarding parameter in class hierarchy.

Reported by: Blackskyliner Owned by: ryan
Priority: normal Milestone: 3.4
Component: General Version: 3.2.1
Severity: normal Keywords: has-patch needs-testing 3.4-early
Cc:

Description

First: Its just a "cosmetic" and PHP5 coding standard patch (or at least you could say, we want to use the PHP5 language the right way).

As I started to write a plugin to Integrate SF2 into Wordpress I got a Notice Error Exception from my SF2 Kernel which stated, that some classes, like the PluginList in the Administration Menu try to overload some function prototypes with a wrong parameter count...

So I just fixed this and now everything works fine, would be great to have this in the Release version, as its against the principles of function prototyping in PHP to overload smth. with the wrong Parameter count.

I just tested the Patch a little bit and found no other errors, but I don't know if I just had luck - or maybe break other plugins with this.

This error is in all versions of WP I tested till now, also I did not found any other patches regarding this problem, hopefully I did not failed to see them ;)

Attachments

patch Download (1.9 KB) - added by Blackskyliner 3 months ago.
SVN diff patch

Change History

SVN diff patch

With SF2 I mean the Symfony2 Framework.

  • Keywords 3.4-early added
  • Version changed from 3.3 to 3.2.1
  • Milestone changed from Awaiting Review to Future Release

Happy with 18975.diff in 3.4.

comment:4   ryan7 weeks ago

  • Milestone changed from Future Release to 3.4

comment:5   ryan7 weeks ago

  • Owner set to ryan
  • Status changed from new to closed
  • Resolution set to fixed

In [19679]:

Clear strict notices for the walkers. fixes #19249

comment:6   dd327 weeks ago

In [19681]:

Revert Debug cruft from [19679], See #19249

Note: See TracTickets for help on using tickets.