Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#19271 closed defect (bug) (fixed)

Change "Close" on New Install Dashboard Welcome Area

Reported by: jane Owned by: georgestephanis
Priority: normal Milestone: 3.3
Component: UI Version: 3.3
Severity: normal Keywords: needs-patch
Cc:

Description

"Close" is a tab a la Screen Options and Help for some reason, instead of being a "x Dismiss" link like in pointers. This is deceptive/confusing since closing this area does not function like the slide down tabs that use that UI element. Let's switch it over to a text Dismiss with the preceding "x" we use on pointers and in Bulk Edit.

Attachments (7)

19271.diff (1.8 KB) - added by georgestephanis 18 months ago.
19271.2.diff (2.2 KB) - added by georgestephanis 18 months ago.
19271.notextshadow.diff (2.4 KB) - added by georgestephanis 18 months ago.
Version with text-shadow turned off for 'Dismiss' link.
19271.3.larger-with-margin.patch (2.5 KB) - added by chexee 18 months ago.
Adds margin and makes font-size 13px
Screen Shot 2011-11-17 at 12.38.11 PM.png (85.9 KB) - added by chexee 18 months ago.
screenshot of 19271.4 patch
19271.4-rtl.patch (432 bytes) - added by chexee 18 months ago.
Updates RTL with new bullet alignment
19271.rtl-fixes.patch (1007 bytes) - added by ocean90 18 months ago.

Download all attachments as: .zip

Change History (20)

  • Owner set to georgestephanis
  • Status changed from new to accepted

On it.

  • Keywords has-patch added; needs-patch removed

Uploading new patch with necessitated change for blue theme as well.

Seems to me you could take out the text shadow too. It looks weird, and inconsistent with the pointer.

Version with text-shadow turned off for 'Dismiss' link.

Adds margin and makes font-size 13px

screenshot of 19271.4 patch

Above patch also realigns bullets with paragraphs.

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19326]:

Change Close tab in Welcome Screen to a Dismiss link. Aligh bullets with paragraphs. Props georgestephanis, chexee. fixes #19271

Chex --

margin: 1.6em 1em 1em 1.3em;

Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.

comment:8 in reply to: ↑ 7   chexee18 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to georgestephanis:

Chex --

margin: 1.6em 1em 1em 1.3em;

Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.

its for the ULs, aligns them flush with the paragraph. and you're right. writing patch now.

Updates RTL with new bullet alignment

In [19351]:

Update RTL bullet alignment on New Install Dashboard Welcome Area, props chexee, see #19271

  • Keywords needs-patch added; has-patch removed

Some RTL issues:

LTR screen: http://cl.ly/BxJm

RTL screen: http://cl.ly/BzQ8

19271.rtl-fixes.patch should fix the RTL issues, but it doesn't do it right. Can't find the error, maybe somebody can continue it.

Last edited 18 months ago by ocean90 (previous) (diff)
  • Resolution set to fixed
  • Status changed from reopened to closed

In [19356]:

RTL refresh for Welcome panel, fixes #19271

In [19363]:

Improve RTL for Welcome panel, refresh css files, see #19271

Note: See TracTickets for help on using tickets.