#19271 closed defect (bug) (fixed)
Change "Close" on New Install Dashboard Welcome Area
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | UI | Version: | 3.3 |
| Severity: | normal | Keywords: | needs-patch |
| Cc: |
Description
"Close" is a tab a la Screen Options and Help for some reason, instead of being a "x Dismiss" link like in pointers. This is deceptive/confusing since closing this area does not function like the slide down tabs that use that UI element. Let's switch it over to a text Dismiss with the preceding "x" we use on pointers and in Bulk Edit.
Attachments (7)
Change History (20)
- Owner set to georgestephanis
- Status changed from new to accepted
georgestephanis — 18 months ago
- Keywords has-patch added; needs-patch removed
georgestephanis — 18 months ago
Uploading new patch with necessitated change for blue theme as well.
Seems to me you could take out the text shadow too. It looks weird, and inconsistent with the pointer.
- Resolution set to fixed
- Status changed from accepted to closed
In [19326]:
comment:7
follow-up:
↓ 8
georgestephanis — 18 months ago
Chex --
margin: 1.6em 1em 1em 1.3em;
Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to georgestephanis:
Chex --
margin: 1.6em 1em 1em 1.3em;
Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.
its for the ULs, aligns them flush with the paragraph. and you're right. writing patch now.
comment:10
ocean90 — 18 months ago
- Keywords needs-patch added; has-patch removed
comment:11
ocean90 — 18 months ago
19271.rtl-fixes.patch should fix the RTL issues, but it doesn't do it right. Can't find the error, maybe somebody can continue it.
comment:12
azaozz — 18 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In [19356]:
comment:13
azaozz — 18 months ago
In [19363]:

On it.