Ticket #1930 (closed defect (bug): fixed)

Opened 6 years ago

Last modified 5 years ago

upgrade code counts spam and moderated when setting comment_count column

Reported by: markjaquith Owned by: markjaquith
Priority: normal Milestone:
Component: Administration Version: 1.6
Severity: major Keywords: bg|has-patch bg|commit
Cc:

Description

When the upgrade code iterates through the posts and sets the comment_count value, it neglects to restrict the value to approved comments ( comment_approved = '1').

Patch fixes it. Also note #1920 for a related bug (comment_count being set incorrectly when comments are submitted, which could perpetuate errors made during the upgrade).

Attachments

comment_count_upgrade.diff Download (713 bytes) - added by markjaquith 6 years ago.
patch for WP 2.0 SVN

Change History

markjaquith — 6 years ago

patch for WP 2.0 SVN

comment:1   markjaquith — 6 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

comment:3   ryan — 6 years ago

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [3192]) Count only approved comments. Props Mark JAquith. fixes #1930

comment:4   anonymous — 5 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.