#19301 closed defect (bug) (fixed)
Superfluous positioning for .ab-top-secondary
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.3 |
| Component: | Toolbar | Version: | 3.3 |
| Severity: | trivial | Keywords: | has-patch |
| Cc: | georgestephanis |
Description
The user menu is floated to the right. It doesn't need the additional positioning rules.
I mark this as a defect because I have a plugin that sets the admin bar to position: absolute and it doesn't work properly now.
Attachments (2)
Change History (11)
comment:3
in reply to:
↑ 1
;
follow-up:
↓ 5
scribu
— 19 months ago
Replying to ocean90:
This is work in progress.
Yes, trunk always is. :P
The reason behind this is to make the my account for small screens available.
Quite interesting. In that case we should lose the float: right.
comment:4
georgestephanis
— 19 months ago
Actually, I set the user menu to
position:fixed;
top:0;
right:0;
(except for RTL, where it flips)
If we just left it as right:0; would it be able to scroll out of screen as expected? Which use case would that be?
And scribu -- can't you just override the CSS changes we've made in trunk in your plugin? Use a higher css specificity level, or get your stylesheet included later?
comment:5
in reply to:
↑ 3
georgestephanis
— 19 months ago
Replying to scribu:
Replying to ocean90:
The reason behind this is to make the my account for small screens available.
Quite interesting. In that case we should lose the float: right.
The float:right ensures that the block-level-element does not occupy all the available width, but is only as wide as it needs to be. We could use display:inline-block to accomplish a similar effect, but I felt that changing fewer things would be better.
comment:6
scribu
— 19 months ago
The float:right ensures that the block-level-element does not occupy all the available width, but is only as wide as it needs to be.
Testing in Firefox and Chrome, float: right doesn't make any difference, no matter the screen size.
This is work in progress.
The reason behind this is to make the my account for small screens available.