Ticket #1932 (closed defect (bug): fixed)

Opened 6 years ago

Last modified 5 years ago

Preview iframe breaks footer

Reported by: ringmaster Owned by: ringmaster
Priority: normal Milestone:
Component: Administration Version: 1.6
Severity: normal Keywords: bg|has-patch
Cc:

Description

The iframe tag is not defined as an EMPTY tag in the XHTML DTD, therefore must be closed with a discrete closing tag, not the empty element shorthand.

As a result of this incorrect closure of the preview iframe, the footer disappears from the page, along with any code (HTML or script) that is added via the admin_footer hook.

The attached patch closes the iframe properly.

Attachments

post.php.diff Download (555 bytes) - added by ringmaster 6 years ago.
Closes the preview iframe with its own dedicated closing tag.

Change History

ringmaster — 6 years ago

Closes the preview iframe with its own dedicated closing tag.

comment:1   ryan — 6 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [3188]) Close iframe properly. Props ringmaster. fixes #1932

comment:2   anonymous — 5 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.