WordPress.org

Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#19327 closed defect (bug) (fixed)

Edit comments and new content items shouldn't be displayed in network admin

Reported by: ocean90 Owned by: ryan
Priority: normal Milestone: 3.3
Component: Toolbar Version: 3.3
Severity: normal Keywords: has-patch
Cc:

Description

At the moment I'm not sure how it was in 3.2, but the edit comments link and new content items don't make sense in network admin IMO.

There is also the new->user item which is linked to wp-admin/new-user.php. But here somebody could think "okay, I'm on network admin so it will link to wp-admin/network/user.php", but it doesn't.

Needs some UI/UX feedback.

Attachments (4)

19327.wp32.png (12.9 KB) - added by SergeyBiryukov 19 months ago.
19327.wp33.png (13.2 KB) - added by SergeyBiryukov 19 months ago.
19327.patch (1.0 KB) - added by SergeyBiryukov 19 months ago.
19327.2.patch (814 bytes) - added by ocean90 19 months ago.

Download all attachments as: .zip

Change History (11)

SergeyBiryukov19 months ago

SergeyBiryukov19 months ago

comment:1 SergeyBiryukov19 months ago

In 3.2, there were no "Edit Comments" or "Add New" links in Network Admin (attached screenshots).

SergeyBiryukov19 months ago

ocean9019 months ago

comment:2 ocean9019 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

In my patch I wrapped only comments menu and new content menu, like we did it in 3.2.

Last edited 19 months ago by ocean90 (previous) (diff)

comment:3 scribu19 months ago

The "Add New" menu should contain "Add Site" and "Add User", both pointing to the appropriate network screens.

comment:4 SergeyBiryukov19 months ago

BTW, shouldn't "Edit Comment" icon have a tooltip, like the "Updates" item?

Version 0, edited 19 months ago by SergeyBiryukov (next)

comment:5 jane19 months ago

  • Keywords ui-feedback removed

I agree. Comments and Add New are site-specific things, don't belong in Network Admin. Yes to comments tooltip also.

comment:6 ryan19 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19398]:

Don't show Add New and Comments admin bar menus in network or user admins. Add tooltip to comments menu. Props ocean90. fixes #19327

comment:7 ryan19 months ago

In [19399]:

Don't forget esc_attr(). see #19327

Note: See TracTickets for help on using tickets.