Opened 18 months ago

Closed 18 months ago

#19331 closed defect (bug) (fixed)

Login screen isn't centered on iPhone

Reported by: ocean90 Owned by: azaozz
Priority: normal Milestone: 3.3
Component: UI Version: 3.3
Severity: normal Keywords: has-patch regression
Cc:

Description

See attached screenshots from iPhone.

Attachments (8)

iOS Simulator Bildschirmfoto 22.11.2011 17.58.39.png​ (33.6 KB) - added by ocean90 18 months ago.
WP 3.3
iOS Simulator Bildschirmfoto 22.11.2011 17.58.53.png​ (38.0 KB) - added by ocean90 18 months ago.
WP 3.2
19331.patch​ (323 bytes) - added by SergeyBiryukov 18 months ago.
19331.2.patch​ (333 bytes) - added by ocean90 18 months ago.
margin instead of padding
19331.3.patch​ (496 bytes) - added by SergeyBiryukov 18 months ago.
19331.diff​ (428 bytes) - added by helenyhou 18 months ago.
Based off of SergeyBiryukov's patch
19331.4.patch​ (581 bytes) - added by SergeyBiryukov 18 months ago.
19331.5.patch​ (613 bytes) - added by SergeyBiryukov 18 months ago.

Download all attachments as: .zip

Change History (19)

ocean90 — 18 months ago

WP 3.3

ocean90 — 18 months ago

WP 3.2

SergeyBiryukov — 18 months ago

comment:1   jane — 18 months ago

  • Keywords has-patch added; needs-patch removed

ocean90 — 18 months ago

margin instead of padding

comment:2 follow-up: ↓ 6   ocean90 — 18 months ago

19331.2.patch​ does fix it for me.

comment:3   ocean90 — 18 months ago

  • Keywords early added
  • Milestone changed from 3.3 to Future Release

comment:4   helenyhou — 18 months ago

19331.2.patch​ has the white stripe at the top again: ​http://cl.ly/0E1U3y0507410n332v3O

comment:5   nacin — 18 months ago

  • Keywords regression added

Technically a regression, yeah? Would be nice to fix.

comment:6 in reply to: ↑ 2   SergeyBiryukov — 18 months ago

Replying to ocean90:

19331.2.patch​ does fix it for me.

That would revert [18737].

SergeyBiryukov — 18 months ago

comment:7   SergeyBiryukov — 18 months ago

  • Keywords early removed
  • Milestone changed from Future Release to 3.3

19331.3.patch​ adjusts wp-login.php for [18737].

helenyhou — 18 months ago

Based off of SergeyBiryukov's patch

comment:8   helenyhou — 18 months ago

19331.diff​ is based off of SergeyBiryukov's patch, adds some space below as well. Didn't even realize there was iPhone magic there :)

SergeyBiryukov — 18 months ago

SergeyBiryukov — 18 months ago

comment:9   SergeyBiryukov — 18 months ago

19331.5.patch​ also aligns messages, navigation links and header image.

comment:10   helenyhou — 18 months ago

Looks good to me. Better than 3.2.1, even.

comment:11   azaozz — 18 months ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19414]:

Align login box, messages, navigation links and header image on the login screen, props SergeyBiryukov and helenyhou, fixes #19331

Note: See TracTickets for help on using tickets.