WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 10 months ago

#19372 new enhancement

Don't call wp_count_comments() when we don't need to

Reported by: johnbillion Owned by:
Priority: normal Milestone: Awaiting Review
Component: Performance Version: 3.2
Severity: minor Keywords: has-patch
Cc:

Description

Comments get counted on every admin screen with wp_count_comments(). We can skip a database call by not counting them if the user doesn't have the edit_posts capability.

Side note: With a persistent object cache it's possible to have admin screens with zero database queries with this patch applied. As an exercise you could write a database class that lazy loads MySQL and you'll get an admin screen that doesn't load MySQL. Almost completely pointless, but interesting nonetheless.

Attachments (1)

19372.patch​ (753 bytes) - added by johnbillion 19 months ago.

Download all attachments as: .zip

Change History (4)

johnbillion — 19 months ago

comment:1 johnbillion — 19 months ago

  • Keywords has-patch added

Patch

comment:2 scribu — 19 months ago

I think 'moderate_comments' would be a more appropriate capability to check. Related: #12104

comment:3 ocean90 — 10 months ago

Related: #11409, #14751

Last edited 10 months ago by ocean90 (previous) (diff)
Note: See TracTickets for help on using tickets.