Opened 18 months ago

Closed 3 months ago

Last modified 3 months ago

#19445 closed defect (bug) (fixed)

Duplicated error code when user is a spammer

Reported by: sirzooro Owned by: SergeyBiryukov
Priority: normal Milestone: 3.6
Component: Multisite Version: 3.0
Severity: normal Keywords: has-patch commit
Cc:

Description

"Your account has been marked as a spammer" message reuses the "invalid_username" error code. Attached path makes it unique. Without it is is impossible to distinguish these two error messages in plugin (e.g. to replace message with generic "invalid user or pass").

Attachments (3)

user.php.diff​ (564 bytes) - added by sirzooro 18 months ago.
user.php.2.diff​ (588 bytes) - added by sirzooro 18 months ago.
path with patches relative to root
19445.diff​ (661 bytes) - added by SergeyBiryukov 4 months ago.

Download all attachments as: .zip

Change History (8)

sirzooro — 18 months ago

comment:1   ocean90 — 18 months ago

Please make your patches relativ to root. Core has more then one user.php. Makes it easier to apply the patch.

sirzooro — 18 months ago

path with patches relative to root

SergeyBiryukov — 4 months ago

comment:2   SergeyBiryukov — 4 months ago

  • Milestone changed from Awaiting Review to 3.6

Makes sense to me. Refreshed.

comment:3   SergeyBiryukov — 4 months ago

  • Keywords commit added

comment:4   SergeyBiryukov — 3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23579:

Use distinct error code in wp_authenticate_username_password() when user is a spammer. props sirzooro. fixes #19445.

comment:5   SergeyBiryukov — 3 months ago

  • Component changed from Users to Multisite
  • Version changed from 3.2.1 to 3.0
Note: See TracTickets for help on using tickets.