Opened 18 months ago

Closed 18 months ago

Last modified 17 months ago

#19479 closed defect (bug) (fixed)

esc_html_e() is only for translations

Reported by: nacin Owned by: ryan
Priority: normal Milestone: 3.3
Component: Widgets Version: 3.3
Severity: normal Keywords: has-patch commit
Cc:

Description


Attachments (1)

19479.diff​ (615 bytes) - added by nacin 18 months ago.

Download all attachments as: .zip

Change History (6)

nacin — 18 months ago

comment:1   nacin — 18 months ago

  • Keywords has-patch commit added

comment:2   ryan — 18 months ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19570]:

Don't use a gettext function for a non-translatable context. Props nacin. fixes #19479

comment:4   nacin — 18 months ago

In [19572]:

Don't use esc_attr_e() function for a non-translatable context. props zeo. fixes #19479.

comment:5   nbachiyski — 17 months ago

For the sake of completeness, I just want to mention that the parser is smart enough to only grab instances of gettext functions where they are called with literal strings. In these cases esc_attr_e() would have worked ok.

Having said that, I agree it's bad style to rely on the parser smartness.

Note: See TracTickets for help on using tickets.