Ticket #1953 (closed defect (bug): fixed)

Opened 6 years ago

Last modified 5 years ago

clean installation not ok as of mysq

Reported by: EdgarM Owned by: ryan
Priority: low Milestone:
Component: Administration Version: 1.6
Severity: normal Keywords: installation mysql default bg|has-patch
Cc:

Description

When installing a new instance of Wordpress 2.0 Beta is not really possible, as several tables have new columns but the columns are not filled via the installationscript.

Also the fix that was mentioned in here:  http://trac.wordpress.org/changeset/3199 will not really help, as of mysql in both 4.x and 5.x Version do not allow defaults in text, mediumtext and longtext fields.

So the bugfix should be the other way around, not to change the default than the inserts in the install.php.

regards EdgarM

PS: The installation does not fail, but most inserts are not executed, so e.g. no post in in the db.

Attachments

comment_parent.diff Download (896 bytes) - added by error 6 years ago.
Set new DB field $comment_parent when comment posted.

Change History

error6 years ago

Set new DB field $comment_parent when comment posted.

  • Keywords bg|has-patch added

One example of this seems to be that comment_parent is unset and MySQL 5 doesn't like this (it's NOT NULL, of course). The attached patch sets comment_parent (to 0). This will probably need to be reworked so that a plugin can override this and provide thhe threaded comments functionality, or it can be put in core, but if that isn't needed, this patch should do fine.

This worked for me, MySQL 5.0/strict.

I have to agree with Edgar though. Fixing the installer should be done by fixing the INSERTs, not by changing the schema.

comment:3   matt6 years ago

  • Priority changed from normal to low

comment:4   ryan6 years ago

  • Owner changed from anonymous to ryan

comment:6   ryan6 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [3285]) Make sure fields without defaults are specified when inserting. fixes #1953

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.