WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 18 months ago

#19655 closed enhancement (invalid)

I fixed a piece of code that used a hack instead of basename()

Reported by: BaylorRae Owned by:
Priority: normal Milestone:
Component: Themes Version: 3.3
Severity: normal Keywords: has-patch
Cc:

Description

Hello I was browsing the source of WordPress wp-admin/includes/theme.php and noticed that it used str_replace() instead of basename().

I've attached my basename-patch.diff file and the updated theme.php file for someone to look over.

---
This is my first time to contribute to WP. I tried to make a commit with SVN but I get a forbidden access error. If you have any suggestions please help.

svn: Commit failed (details follow):
svn: access to '/!svn/act/33767141-9196-41b2-926e-d24cd5f0aa35' forbidden

Attachments (2)

basename-patch.diff​ (622 bytes) - added by BaylorRae 18 months ago.
The SVN diff
theme.php​ (13.4 KB) - added by BaylorRae 18 months ago.
Includes my change

Download all attachments as: .zip

Change History (6)

BaylorRae — 18 months ago

The SVN diff

BaylorRae — 18 months ago

Includes my change

comment:2 BaylorRae — 18 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Ah, okay. I didn't think about subdirectories.

comment:3 helenyhou — 18 months ago

  • Milestone Awaiting Review deleted

comment:4 Ipstenu — 18 months ago

For the totally unrelated answer.

You can't commit to core. Submit a diff file by attaching it to your trac ticket and, if the gods smile, it will be accepted.

Note: See TracTickets for help on using tickets.