Death "Add Media" link after permanently deleting media items.

[Jordi-Fun]

After deleting a media item permanently and try to directly add a new one via the 'title-menu-link' (the button-link near the "Media" title in the admin screen) will result in a death link ("Invalid post type").

Follow these steps to reproduce the death link(s):

If you have no unattachted media in your library, first do this:

• Media > Add New
• From the 'title' menu "Add New" (Button near "Media Library" at the top)
• Add a random image/file and press "Save changes"
• You'll get redirected back to the overview of all your media.

If you already have one or more unattached media items in the library:

• Click on the "Delete Permanently" link of the file you just uploaded (the unattached file) (and press oke in the alert dialog)
• This is where something goes wrong: You'r now redirected to the edit.php page where you can read: "Item permanently deleted.". Now click again on the "Add New" link in the title-menu near the title "Media"
• You're now redirected to an invalid page: "Invalid post type".

Replying to Jordi-Fun:

• This is where something goes wrong: You'r now redirected to the edit.php page where you can read: "Item permanently deleted.". Now click again on the "Add New" link in the title-menu near the title "Media"

Is this a clean install? I'm being redirected to upload.php, not edit.php, and the message I get is "Media attachment permanently deleted.".

Replying to linuxologos:

Replying to Jordi-Fun:

• This is where something goes wrong: You'r now redirected to the edit.php page where you can read: "Item permanently deleted.". Now click again on the "Add New" link in the title-menu near the title "Media"

Is this a clean install? I'm being redirected to upload.php, not edit.php, and the message I get is "Media attachment permanently deleted.".

I will try again with a clean install. I found this bug a few weeks ago when it was a clean install, but in the meantime I've installed some themes and pluguins and upgraded to the latest version.

Checked again, and I left 1 plugin active, but also deactivated I still have this issue. I'll test it out as soon as possible with a clean install.

I was able to reproduce this bug again on a clean (3.3.1) install. If needed I can provide access to my (clean - 3.3.1) wordpress install.

I can reproduce with referers disabled. The page that says "Invalid post type" is post-new.php?post_type=attachment.

Adding _wp_http_referer to delete links in _get_row_actions() (similarly to WP_MS_Users_List_Table) fixes this.

The patch also improves readability a bit.