Trim code from Twenty Eleven theme-options

[emhr]

Suggest removal of the conditional statement for add_option() in twentyeleven_theme_options_init()

The function twentyeleven_get_theme_options() uses get_option() and sets the $default parameter.

The conditional statement will never evaluate twentyeleven_get_theme_options() as false. This is probably an artifact from a previous release. As far as I can tell, removing it has no effect to the current revision except for trimming code.

For a new install this would mean an additional SQL each page load until they do something to cause the options to be set (for example, setting a theme option).

Hmm, yes, it is an artifact. The goal was to avoid an extra query, as dd32 writes. 19743.diff​ is what was intended.

Where is the extra query generated?

If the option doesn't exist in the database, it won't get auotloaded, which means WordPress needs to hit the options table to check for that individual row.

Thanks

I think there's no need to save options into DB, before user save theme from options panel. Twenty Twelve is going use this solution and Lance mentioned, that Nacin had same idea for Twenty Eleven. The diff above removes it.

In [20875]:

Remove some dead add_option() code in Twenty Eleven. props Mamaduka, emhr. fixes #19743