Opened 17 months ago

Closed 13 months ago

Last modified 13 months ago

#19786 closed defect (bug) (worksforme)

make sure $step is an integer. some space fixes.

Reported by: Caspie Owned by:
Priority: normal Milestone:
Component: Upgrade/Install Version:
Severity: normal Keywords: has-patch
Cc:

Description

Make sure the step variable is an integer if isset

Attachments (1)

19786.diff​ (3.0 KB) - added by Caspie 17 months ago.

Download all attachments as: .zip

Change History (7)

Caspie — 17 months ago

comment:1   DrewAPicture — 17 months ago

  • Keywords has-patch added

comment:2   DrewAPicture — 17 months ago

  • Version set to 3.3.1

comment:3   linuxologos — 17 months ago

  • Version 3.3.1 deleted

That piece of code is much much older! Actually from the beginning. ;)

comment:4   SergeyBiryukov — 17 months ago

  • Milestone changed from Awaiting Review to 3.4

comment:5   nacin — 13 months ago

  • Milestone 3.4 deleted
  • Resolution set to worksforme
  • Status changed from new to closed

$step = isset( $_GET['step'] ) ? (int) $_GET['step'] : 0; is already in core.

Last edited 13 months ago by nacin (previous) (diff)

comment:6   nacin — 13 months ago

In [20618]:

Int cast a step variable. see #19786. props Caspie.

Note: See TracTickets for help on using tickets.