Ticket #19850 (closed enhancement: fixed)

Opened 4 months ago

Last modified 5 weeks ago

double slash in URL when editing gallery in visual mode

Reported by: h8every1 Owned by: azaozz
Priority: normal Milestone: 3.4
Component: Gallery Version: 2.7
Severity: normal Keywords: has-patch
Cc:

Description

reproduce:

  1. upload images
  2. insert gallery into the editor
  3. in "Visual" mode hover over the gallery placeholder and click the edit button
  4. a pop-up shows, which URL is 'wp-admin//media-upload.php'

it works all right with vanilla install, but with some anti-hacker enhancements to .htaccess (5G Firewall) it breaks because of double slash.

Attachments

19850.patch Download (817 bytes) - added by SergeyBiryukov 4 months ago.

Change History

SergeyBiryukov — 4 months ago

comment:1   SergeyBiryukov — 4 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.4

According to  TinyMCE documentation, documentBaseURL must end with a slash, so the additional slash is not needed.

Seems that the compressed file is always loaded (regardless of SCRIPT_DEBUG), so in order to test the patch I had to alter wpgallery/editor_plugin.js as well.

There's also a  support forum thread about this issue.

comment:2   SergeyBiryukov — 4 months ago

  • Version changed from 3.3.1 to 2.7

comment:4   azaozz — 5 weeks ago

  • Owner set to azaozz
  • Status changed from new to closed
  • Resolution set to fixed

In [20519]:

Remove extra slash when opening the gallery thickbox popup from the visual editor, props SergeyBiryukov, fixes #19850

Note: See TracTickets for help on using tickets.