Formatting from code block during network setup doesn't match wp-config.php

[ryanduff]

In the process of network setup the block of code generate to be pasted into wp-config.php uses single space padding within parentheses. This doesn't match the rest of the formatting in wp-config.php

Simple code consistency fix.

I'm not sure this is valid. I know that WordPress  coding standards normally calls for single spaces inside of opening and closing parentheses with functions and on both sides with if, foreach and switch statements. Shouldn't defining constants follow a similar pattern?

Shouldn't defining constants follow a similar pattern?

They should.

Shouldn't defining constants follow a similar pattern?

They should.

Maybe this should be the other way around, but not even the salts generator has spaces.

I'd still vote for consistency though. Perhaps we should update wp-config-sample.php as per coding standards then?

Replying to SergeyBiryukov:

I'd still vote for consistency though. Perhaps we should update wp-config-sample.php as per coding standards then?

I can open a ticket. The salts generator would have to be updated too.

Edit: #19870

Replying to SergeyBiryukov:

I'd still vote for consistency though. Perhaps we should update wp-config-sample.php as per coding standards then?

This was one of those that could go either way. Which file do you choose to fix and why... Agreed though, the changes probably should be in wp-config-sample.php

But at least it was brought to awareness. Sorry on the delayed reply... timezones ;)

From @nacin's comment:ticket:19870:3 in #19870

I'd rather just re-open #19869 and remove the spaces from multisite. We have slightly different standards for user-edited files as it is (for example, line endings), and I'd rather not cause confusion or have extra work done over a few spaces in a define() call.

This is really small and related, sorry if I should open a new ticket about this.

wp-config-sample.php is also missing the ?> php closing tag at the end.

Replying to MZAWeb:

This is really small and related, sorry if I should open a new ticket about this.

wp-config-sample.php is also missing the ?> php closing tag at the end.

There are various reasons for that. For starters, its optional. Secondly, it can help avoid whitespace issues that may cause the common white screen of death error.

Replying to MZAWeb:

wp-config-sample.php is also missing the ?> php closing tag at the end.

It was intentionally removed in #6791. Also came up in #10106.

In [19956]:

Align the spacing of the multisite constants with what has been long-established in wp-config and wp-config-sample. props ryanduff, fixes #19869.