Opened 16 months ago
Closed 13 months ago
#19923 closed defect (bug) (fixed)
admin colors-*.css needs foreground color in form inputs
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.4 |
| Component: | UI | Version: | 3.3.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
The colors-fresh style sheet sets the background color of form inputs to white but does not set a foreground color. This leads to problems for people who have non-standard browser preferences. A patch is attached that colors the text black.
Attachments (4)
Change History (17)
comment:1
SergeyBiryukov — 16 months ago
- Component changed from General to UI
- Keywords has-patch ui-feedback added; form foreground background color removed
comment:2
SergeyBiryukov — 16 months ago
- Milestone changed from Awaiting Review to 3.4
- Summary changed from colors-fresh needs foreground color in form inputs to admin colors-*.css needs foreground color in form inputs
So ignore the first patch, please.
comment:5
SergeyBiryukov — 16 months ago
- Keywords commit added; ui-feedback removed
- Owner set to helenyhou
- Status changed from new to reviewing
The first patch also applies to inputs, so some juggling will need to occur here.
If using an earlier patch, make sure to apply the same change to both the classic and fresh css files.
Further investigation indicates that inputs also ignore the body's declaration of color and use browser styles instead. Freaking forms. Let's go with #000 for all of the above as per browser default and to keep it simple. New patch for both colors-*.css incoming.
comment:10
helenyhou — 13 months ago
Actually ran across a duplicate: #11645. Has similar patch, but specifies colors that won't end up working well for selects in Webkit.
comment:11
ryan — 13 months ago
- Resolution set to fixed
- Status changed from reviewing to closed
In [20659]:
comment:12
helenyhou — 13 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Per koop, we should lighten up the foreground color for inputs to match the body, since the background is white. Selects need to stay black, as there's that pesky gray background in Webkit. 19923.2.diff
comment:13
koopersmith — 13 months ago
- Resolution set to fixed
- Status changed from reopened to closed
In [20748]:

helenyhou suggested that #333 would be better than #000. Please adjust the patch accordingly if deemed more appropriate.